Update from 5.4 to 5.36.1 : problem to Update smart groups to rename filters on case_from and case_to to case_start_date and case_end_date

Question

In Drupal 7, after this long update from 5.4 to 5.36.1 in a CiviCRM which I take administration, I had 2 blocking errors in the sites/all/modules/civicrm/CRM/Upgrade/Incremental/php/FiveTwenty.php file. I commented on the 2 lines that are problematic and the update could be done completely :

    $this->addTask('Update smart groups to rename filters on case_from and case_to to case_start_date and case_end_date', 'updateSmartGroups', [
  'renameField' => [
    ['old' => 'case_from_relative', 'new' => 'case_start_date_relative'],
    ['old' => 'case_from_start_date_high', 'new' => 'case_start_date_high'],
    ['old' => 'case_from_start_date_low', 'new' => 'case_start_date_low'],
    ['old' => 'case_to_relative', 'new' => 'case_end_date_relative'],
    ['old' => 'case_to_end_date_high', 'new' => 'case_end_date_high'],
    ['old' => 'case_to_end_date_low', 'new' => 'case_end_date_low'],
    ['old' => 'mailing_date_relative', 'new' => 'mailing_job_start_date_relative'],
    ['old' => 'mailing_date_high', 'new' => 'mailing_job_start_date_high'],
    ['old' => 'mailing_date_low', 'new' => 'mailing_job_start_date_low'],
    ['old' => 'relation_start_date_low', 'new' => 'relationship_start_date_low'],
    ['old' => 'relation_start_date_high', 'new' => 'relationship_start_date_high'],
    ['old' => 'relation_start_date_relative', 'new' => 'relationship_start_date_relative'],
    ['old' => 'relation_end_date_low', 'new' => 'relationship_end_date_low'],
    ['old' => 'relation_end_date_high', 'new' => 'relationship_end_date_high'],
    ['old' => 'relation_end_date_relative', 'new' => 'relationship_end_date_relative'],
    ['old' => 'event_start_date_low', 'new' => 'event_low'],
    ['old' => 'event_end_date_high', 'new' => 'event_high'],
  ],
]);

and 3 lines after, from 120 to 134 :

    $this->addTask('Update smart groups where jcalendar fields have been converted to datepicker', 'updateSmartGroups', [
  'datepickerConversion' => [
    'birth_date',
    'deceased_date',
    'case_start_date',
    'case_end_date',
    'mailing_job_start_date',
    'relationship_start_date',
    'relationship_end_date',
    'event',
    'relation_active_period_date',
    'created_date',
    'modified_date',
  ],
]);

Can anyone tell me if the 2 commented lines will pose a problem later and how to manually perform the operations left out?

I found this question but I didn't know what to do in my case : Upgrade fails with CiviCRM_API3_Exception: "API error: Could not delete payment processor type"

Answer 1

Those upgrade steps are updating particular fields in smartgroups. If you don't have any smart groups using those fields, it won't matter... but if those steps are failing it suggests you do have affected smart groups and those won't work correctly. You could delete those groups and recreate them.

But the underlying question is why is the upgrade hitting problems? If for example the field renames have failed, that will cause you more trouble in the future. I suggest you post the errors from the logs for the failing upgrade steps so we can diagnose the cause.